@Crease29 opened this Pull Request on October 1st 2019 Contributor

While reading your Matomos contributing guide, I saw, that Matomo is sticking to PSR-1, PSR-2 and PSR-4. I digged into the code and saw some closing PHP tags, which must be omitted (see: https://www.php-fig.org/psr/psr-2/#22-files).

There are also closing PHP tags in libs/HTML but I wasn't sure, if these should be touched.

@tsteur commented on October 1st 2019 Member

@Crease29 thanks for this. You updated the custom alerts submodule which makes the tests fail see https://travis-ci.org/matomo-org/matomo/jobs/592136762#L533 could you revert the submodule change?

@Crease29 commented on October 3rd 2019 Contributor

Sorry for the amount of pushes. I messed something up here when reverting the previous commit. Should be fine now 🙂

Edit: I'd also like to fix some other PHPDoc and code style issues. Is that something that is welcome or wouldn't that be of value for you?

@tsteur commented on October 3rd 2019 Member

Cheers @Crease29 for fixing the PR will merge now.

Sure we appreciate such PRs as long as they don't change any logic and are easy to review and quick to merge before any merge conflicts happen :)

This Pull Request was closed on October 3rd 2019
Powered by GitHub Issue Mirror