Removed closing PHP tag due to PSR-2 definition #14929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Crease29 thanks for this. You updated the custom alerts submodule which makes the tests fail see https://travis-ci.org/matomo-org/matomo/jobs/592136762#L533 could you revert the submodule change? |
|
Sorry for the amount of pushes. I messed something up here when reverting the previous commit. Should be fine now 🙂 Edit: I'd also like to fix some other PHPDoc and code style issues. Is that something that is welcome or wouldn't that be of value for you? |
|
Cheers @Crease29 for fixing the PR will merge now. Sure we appreciate such PRs as long as they don't change any logic and are easy to review and quick to merge before any merge conflicts happen :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading your Matomos contributing guide, I saw, that Matomo is sticking to PSR-1, PSR-2 and PSR-4. I digged into the code and saw some closing PHP tags, which must be omitted (see: https://www.php-fig.org/psr/psr-2/#22-files).
There are also closing PHP tags in
libs/HTMLbut I wasn't sure, if these should be touched.