Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When checking if directory is writable, do not prepend user path or include path #14928

Merged
merged 1 commit into from Oct 2, 2019
Merged

When checking if directory is writable, do not prepend user path or include path #14928

merged 1 commit into from Oct 2, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 1, 2019

This fixes eg when path.tmp in DI is pointing to a different path outside the user path, and outside the document root / include path.

I checked all usages call it with absolute paths anyway.

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 1, 2019
@tsteur tsteur added this to the 3.12.0 milestone Oct 1, 2019
@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Oct 1, 2019
@tsteur tsteur merged commit e4f5475 into 3.x-dev Oct 2, 2019
@tsteur tsteur deleted the directorycheck branch October 2, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tsteur