Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP method needs to return true when a destination path is given #14921

Merged
merged 1 commit into from Sep 30, 2019
Merged

HTTP method needs to return true when a destination path is given #14921

merged 1 commit into from Sep 30, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 30, 2019

In #14877 I added a new feature so plugins can hook into HTTP. Now noticed the GeoIP download was not working because it didn't return true when the response was loaded into a file.

@tsteur
HTTP method needs to return true when a destination path is given
3e725cd 
In #14877 I added a new feature so plugins can hook into HTTP. Now noticed the GeoIP download was not working because it didn't return true when the response was loaded into a file.
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 30, 2019
@tsteur tsteur added this to the 3.12.0 milestone Sep 30, 2019
sgiehl
sgiehl reviewed Sep 30, 2019
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, but code looks fine. Should we maybe add a test to check that true is returned in that case, to avoid future failures when the method is changed again?

@tsteur tsteur merged commit 0fc4d1d into 3.x-dev Sep 30, 2019
@tsteur tsteur deleted the file_download_http branch September 30, 2019 20:01
@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl left review comments

Assignees
No one assigned
Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl