Fix transaction level capability check #14920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
not-in-changelog
tsteur
reviewed
Sep 30, 2019
| @@ -37,12 +40,15 @@ public function canLikelySetTransactionLevel() | |||
|
|
|||
| public function setUncommitted() | |||
| { | |||
| $backup = $this->db->fetchOne('SELECT @@TX_ISOLATION'); | |||
There was a problem hiding this comment.
@diosmosis does this need to be $this->statusBackup instead of $backup?
There was a problem hiding this comment.
That's done below after successfully changing it. If it fails for some reason to set it then we don't need to set it back.
|
@diosmosis fyi I'm now getting an error
with MySQL8. Will investigate and create PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.