Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.6.4-rc4] Minor localization regression? #1492

Closed
anonymous-matomo-user opened this issue Jul 21, 2010 · 1 comment
Closed

[0.6.4-rc4] Minor localization regression? #1492

anonymous-matomo-user opened this issue Jul 21, 2010 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone

Comments

@anonymous-matomo-user
Copy link

...
--- latest-0.6.3/piwik/core/Tracker/GoalManager.php Mon May 31 13:57:22 2010
+++ piwik-0.6.4-rc4/piwik/core/Tracker/GoalManager.php  Tue Jun 29 12:06:58 2010
@@ -52,7 +52,7 @@
                return $goal;
            }
        }
-       throw new Exception(Piwik_TranslateException('General_ExceptionGoalNotFound', array($idGoal)));
+       throw new Exception('Goal not found');
    }

    static public function getGoalIds( $idSite )

...
--- latest-0.6.3/piwik/core/Tracker/Visit.php   Mon May 31 13:57:22 2010
+++ piwik-0.6.4-rc4/piwik/core/Tracker/Visit.php    Tue Jul 06 02:04:36 2010
@@ -62,7 +82,7 @@
        Piwik_PostEvent('Tracker.setRequest.idSite', $idsite);
        if($idsite <= 0)
        {
-           throw new Exception(Piwik_TranslateException('General_ExceptionInvalidIdsite'));
+           throw new Exception('Invalid idSite');
        }
        $this->idsite = $idsite;
    }

Keywords: regression

@mattab
Copy link
Member

mattab commented Jul 21, 2010

These exceptions should not be displayed to the user via normal UI use, so removed unused translation. If it is displayed somewhere please reopen

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

2 participants