Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If session was already started, do not start it again #14896

Merged
merged 4 commits into from Sep 22, 2019
Merged

If session was already started, do not start it again #14896

merged 4 commits into from Sep 22, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 17, 2019 •
edited

refs #12963
refs https://forum.matomo.org/t/an-error-occurred/32500

A session may be already started by some other platform when Matomo is embedded like this: https://developer.matomo.org/guides/querying-the-reporting-api

@tsteur tsteur added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Sep 17, 2019
@tsteur tsteur added this to the 3.12.0 milestone Sep 17, 2019
@tsteur tsteur added the Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. label Sep 17, 2019
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. labels Sep 17, 2019
@diosmosis
Copy link
Member

Can a system test be added for this? Something like:

  • use Platform.initialized in a test case to manually start a session
  • send an http request to matomo that would fail w/o these changes

@tsteur
Copy link
Member Author

tsteur commented Sep 22, 2019

@diosmosis done... without the patch the page would have a fatal error

@diosmosis diosmosis merged commit 83e025e into 3.x-dev Sep 22, 2019
@diosmosis diosmosis deleted the 12963 branch September 22, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @diosmosis