@katebutler opened this Pull Request on September 10th 2019 Member

Fixes #14745

@tsteur commented on September 16th 2019 Member

@katebutler could we change the "Test" button to look for example like the "CLOSE" button?

In general not sure about the behaviour. It's great the segment selector stays open so we can create the segment afterwards. But when no visit matches or only one, or when an error happens then nothing can be seen see
image

It's almost as it would need to push the content for the visitor log down only in this special case when clicking on test
image

@diosmosis since you created the issue any thoughts on this?

@diosmosis commented on September 16th 2019 Member

Not sure how to solve this problem. I suppose alternatively, we could load the segmented visitor log in a modal when test is clicked. Think that would make a difference?

@tsteur commented on September 16th 2019 Member

Not sure. Modal likely won't work either as it would still hide the partial result. Only thing I can imagine is pushing the content for the visitor log further down when using the test feature. That should also be easy to do I reckon. There be other options like loading the visits log in the segment editor but this can be tricky... alternatively we could check how many visits match a given segment when clicking on test and show the result as a modal or so. Maybe showing the matching visits in the last X hours be enough?

@diosmosis commented on September 16th 2019 Member

Modal likely won't work either as it would still hide the partial result.

Wouldn't the modal be on top of everything else? I'm not sure how it would be hidden.

@tsteur commented on September 16th 2019 Member

I see you meant showing the visits log in modal not the segment editor? Could work... just not sure what it looks like ... there's minimal space and there's usually a grey background etc.

I now wonder what is the best way for a user to verify it works anyway? Like a number of matching visits? Showing a few visits? How many visits? How can a user be best sure it's working? Showing a number of matching visits plus a few example visits? Is there anything else how a user can be certain the segment is correct?

Would it work to maybe open the test button in a new window? (not best UX though)

@diosmosis commented on September 16th 2019 Member

Thought about showing the number of visits too. It might work, if the user trusts that the matched visits are correct... but then the segment might work but match the wrong visits and the user would need to see that. It's probably best to show some visits, what do you think?

@tsteur commented on September 16th 2019 Member

Yeah I reckon showing some visits is certainly helpful. The segment might still not be expected but I suppose you can never 100% test / verify it and we can always tweak over time if users have some good ideas on how to best validate a segment with additional information.

If MySQL was faster we would directly show for each condition within a segment the number of matched visits and the number of matched visits for the entire segment even before clicking on test... but it wouldn't be fast enough and put quite some load on it.

@diosmosis commented on September 17th 2019 Member

What if we only show the first matched visit? That might be enough to check that it's matching the right criteria. Unless the user uses an 'OR'.

We could also figure this problem out later if it's not a blocker.

EDIT: Disclaimer: I have no idea how important this issue is.

@tsteur commented on September 17th 2019 Member

Sounds good. Some simple solution be good

@tsteur commented on October 2nd 2019 Member

@katebutler could you look at the merge conflicts?

@tsteur commented on October 2nd 2019 Member

@katebutler just gave it a test...

  • When the visitor log popup is open, and I click on escape, then it closes the segment editor but not the popover with the visitor log. Would have expected it the other way around that it closes the visitor log popover. Tested it with other popovers there the esc key doesn't seem to work either. Eg when opening a report, then clicking on the export icon. So maybe the workaround would be to not close the segment editor while the visitor log is open when esc is clicked. This we would likely need to be implemented in the bindEvents method in Segmentation.js

  • Around https://github.com/matomo-org/matomo/pull/14884/files#diff-4e4c0250d8a0ec9660276e396757f6efR760 could we maybe also add another URL parameter like &inPopover=true and then in the visitor log visualisation, in the beforeRender method (https://github.com/matomo-org/matomo/blob/3.12.0-b4/plugins/Live/Visualizations/VisitorLog.php#L115) we could maybe hide the export icon, the paging information, the limit selector, and set the limit selector hard coded to say 5 or 10? like $view->config->show_XYZ= false etc?

Noticed the segment editor disappears in the background when otherwise changing for example the number of shown visits and we wouldn't want to load too many there anyway maybe. Also when clicking on export the popover gets lost otherwise etc.

@tsteur commented on October 4th 2019 Member

@katebutler is it possible to also when the popover is open, and someone clicks in the background, to only close the popover and not the segment editor?

This Pull Request was closed on October 7th 2019
Powered by GitHub Issue Mirror