Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique Visitors metric appear in Graph metric selector for periods for which the metric is disabled #14881

Closed
mattab opened this issue Sep 10, 2019 · 4 comments · Fixed by #14885 or #14996
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Sep 10, 2019

Unique Visitors metric appear in Graph metric selector for periods for which the metric is disabled, causing confusion amongst users. And also many support requests to our team.

--> When Unique Visitors metric is disabled for the currently selected period, let's hide it from the evolution graph metric picker.

This is what it currently looks like (no data for Unique Visitors):
Screenshot from 2019-09-10 16-09-37

@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Sep 10, 2019
@mattab mattab added this to the 3.12.0 milestone Sep 10, 2019
@sgiehl sgiehl self-assigned this Sep 10, 2019
@mattab
Copy link
Member Author

mattab commented Sep 30, 2019

It is working for the main use case, but there is still a little issue:

  • Open a weekly report, plot the Unique Visitors metric in the graph.
  • Switch to the monthly report by eg. double click on "month" radio in calendar
  • The evolution graph still shows Unique Visitors metric with 0 values:

Screenshot from 2019-09-30 13-07-59

-> Even when the metrics are saved as user preferences, the "Unique visitors" metric preference should be ignored when the Unique Visitors feature is disabled for the currently selected period.

@mattab mattab reopened this Sep 30, 2019
@mattab
Copy link
Member Author

mattab commented Oct 8, 2019

@sgiehl are you able to fix this issue maybe?

@sgiehl
Copy link
Member

sgiehl commented Oct 11, 2019

@mattab That's are more general problem that needs to be solved. It might always be possible that a metric that is selected for display might become unavailable. E.g. if a plugin metric is chosen and the plugin is disabled.

Also it is not possible to simply remove the metric from the list, as it could then happen that no metric to display remains. In this case a default metric might need to be displayed. But how would such a default metric be determined? The first metric appearing in the report?

Imho we should plan for Matomo 4 to create a metric class for every existing metric. That way we can simply use such classes to check if a metric is available and maybe even use those classes to define alternative metrics to display if one is not available.

@mattab
Copy link
Member Author

mattab commented Oct 11, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
2 participants