Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Zend Config #14875

Merged
merged 1 commit into from Sep 10, 2019
Merged

remove Zend Config #14875

merged 1 commit into from Sep 10, 2019

Conversation

Findus23
Copy link
Member

@Findus23 Findus23 commented Sep 9, 2019

I think (and PHPstorm tends to agree) that this code isn't used. It seems to consist of old PHP code that implements things that are already done differently in Matomo and uses deprecated PHP features like each().

The tests will show if this is really unused.

@tsteur
Copy link
Member

tsteur commented Sep 10, 2019

LGTM for me. I see Zend_Config is being used itself a few times but you're keeping that file in the repo so should be all fine.

@tsteur tsteur merged commit 14c4688 into 3.x-dev Sep 10, 2019
@tsteur tsteur deleted the remove-zend-config branch September 10, 2019 00:16
@Findus23 Findus23 restored the remove-zend-config branch October 4, 2019 09:48
@sgiehl sgiehl deleted the remove-zend-config branch February 10, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Findus23 @tsteur