Make it easier to search help resources from within Matomo #14870
Conversation
katebutler
added
the
Pull Request WIP
katebutler
changed the title
| <li class="quick-access-category helpCategory">{{ 'General_HelpResources' | translate }}</li> | ||
| <li ng-class="{selected: search.index == 'help'}" | ||
| ng-mouseenter="search.index='help'"> | ||
| <a href="https://matomo.org?s={{ urlEncode(search.term) }}" target="_blank">Search '{{ search.term }}' on matomo.org</a> |
There was a problem hiding this comment.
@katebutler this string needs to be translatable... like {{ 'foobar_xyz'|translate:search.term }}
| <li class="quick-access-category helpCategory">{{ 'General_HelpResources' | translate }}</li> | ||
| <li ng-class="{selected: search.index == 'help'}" | ||
| ng-mouseenter="search.index='help'"> | ||
| <a href="https://matomo.org?s={{ urlEncode(search.term) }}" target="_blank">Search '{{ search.term }}' on matomo.org</a> |
There was a problem hiding this comment.
Might also need to check if ng-href is a better fit. Might be more secure and might not need the urlencode then. Not 100% sure though but think so
katebutler
added
Needs Review
| @@ -36,5 +36,13 @@ | |||
| ng-click="quickAccess.selectSite(site.idsite)" | |||
| ng-repeat="site in quickAccess.sitesModel.sites"><a ng-bind="site.name"></a></li> | |||
| </ul> | |||
| <ul> | |||
There was a problem hiding this comment.
@katebutler could wee add a CSS class quickAccessMatomoSearch here (or similar name) then we can disable this maybe through whitelabel when needed.
| <div class="search-matomo-form"> | ||
| <div> | ||
| <span class="icon-search"></span> | ||
| <input type="text" placeholder="{{'Feedback_SearchHelpResources'|translate|e('html_attr')}}" name="s"/> |
There was a problem hiding this comment.
This isn't using our form widgets like <div piwik-field uicontrol="text"....>
There was a problem hiding this comment.
Might need also generally need to look more like a search field maybe like but with the icon on the left
BTW we're using MaterializeCSS see http://archives.materializecss.com/0.100.2/shadow.html so we could use classes like z-depth-1. If we make the search look like above we would maybe not need to reuse our builtin widgets.
In general be good to improve the look a bit. Could we maybe make it look like this?
(the search icon needs to be vertically centered)
| @@ -8,6 +8,24 @@ | |||
| {% block content %} | |||
|
|
|||
| <div id="feedback-faq" class="admin"> | |||
| <div piwik-content-block content-title="{{ "Feedback_HowCanWeHelp"|translate|e('html_attr') }}" class="feedback-help-resources"> | |||
There was a problem hiding this comment.
I reckon be good to move this section under "About Matomo".
We then need to see how to further optimise it as there will be three different help sections... Community help also partially repeats the guides and FAQs. People might not notice the community help and professional help section when we show the "how can we help" section...
@katebutler
could you merge the three sections into one section similar to this?
# Conflicts: # plugins/Feedback/tests/UI/expected-screenshots/FeedbackForm_show.png
mattab
added
the
not-in-changelog
Fixes #14626