Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop urlencoding dashboard names before sending to API #14869

Merged
merged 1 commit into from Sep 10, 2019
Merged

Conversation

katebutler
Copy link

When sent as plain text, the dashboard names are passed through htmlspecialchars before they are written to the DB, so they can still be used in their raw form in the UI.
Fixes #14820

@katebutler katebutler added this to the 3.12.0 milestone Sep 8, 2019
@katebutler katebutler added the Needs Review PRs that need a code review label Sep 8, 2019
@tsteur tsteur merged commit a1cba09 into 3.x-dev Sep 10, 2019
@tsteur tsteur deleted the 14820 branch September 10, 2019 21:49
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 25, 2019
@jbrule
Copy link

jbrule commented Mar 10, 2020

I'm seeing url encoded dashboard names and I wonder if this PR is related. I am on v3.13.3.

Screen Shot 2020-03-10 at 1 26 46 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard title with space
4 participants