Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shown logo in the app #14860

Merged
merged 6 commits into from Sep 13, 2019
Merged

Update shown logo in the app #14860

merged 6 commits into from Sep 13, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 5, 2019

fix #14795

@tsteur tsteur added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Sep 5, 2019
@tsteur tsteur added this to the 3.12.0 milestone Sep 5, 2019
@tsteur
Copy link
Member Author

tsteur commented Sep 5, 2019

@Findus23 or @diosmosis do you maybe have an idea why the icons would slightly change when nothing else changes and the PR shouldn't change it? There seem to be minor changes will icons in the all the screenshots https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/35792/UIIntegrationTest_dashboard1.png

@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Sep 5, 2019
@tsteur
Copy link
Member Author

tsteur commented Sep 5, 2019

Before I update all screenshots and they become outdated again etc it be good to review this issue. Looking at https://builds-artifacts.matomo.org/matomo-org/matomo/14795/35795/
makes it also easier to review the updated screenshots. Once it is fine I will update the screenshots and fix the tests

@diosmosis
Copy link
Member

The icons look the same to my eye, maybe a change here subtly changes how chrome renders the icons. The size is the same and it basically looks the same, so I suppose it's ok to just copy over the screenshots?

@tsteur
Copy link
Member Author

tsteur commented Sep 7, 2019

Updated the screenshots @diosmosis

@diosmosis diosmosis merged commit 703ed94 into 3.x-dev Sep 13, 2019
@diosmosis diosmosis deleted the 14795 branch September 13, 2019 05:39
@Findus23 Findus23 mentioned this pull request Oct 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

Show Matomo logo in the app
2 participants
@tsteur @diosmosis