@tsteur opened this Pull Request on September 5th 2019 Member
@tsteur commented on September 5th 2019 Member

@Findus23 or @diosmosis do you maybe have an idea why the icons would slightly change when nothing else changes and the PR shouldn't change it? There seem to be minor changes will icons in the all the screenshots https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/35792/UIIntegrationTest_dashboard1.png

@tsteur commented on September 5th 2019 Member

Before I update all screenshots and they become outdated again etc it be good to review this issue. Looking at https://builds-artifacts.matomo.org/matomo-org/matomo/14795/35795/
makes it also easier to review the updated screenshots. Once it is fine I will update the screenshots and fix the tests

@diosmosis commented on September 7th 2019 Member

The icons look the same to my eye, maybe a change here subtly changes how chrome renders the icons. The size is the same and it basically looks the same, so I suppose it's ok to just copy over the screenshots?

@tsteur commented on September 7th 2019 Member

Updated the screenshots @diosmosis

This Pull Request was closed on September 13th 2019
Powered by GitHub Issue Mirror