New INI setting live_query_max_execution_time to allow configuration of max execution time #14858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
reviewed
Sep 7, 2019
| throw $e; | ||
| } | ||
| return $visits; | ||
| } |
There was a problem hiding this comment.
This code seems important. Would it be possible to unit/integration test this code w/ a mock Db object returned by Db::getReader()?
|
Unfortunately this syntax isn't supported in MariaDB which has another synax to set the maximum execution time for a query: |
|
thanks @Findus23 I will mention in the config that it likely won't work on MariaDB |
|
Added some tests @diosmosis |
mattab
changed the title
mattab
added
c: Performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mattab
Users can now optionally configure a max_execution_time for live queries to prevent a live query from running for a very long time eg when looking at a year with a segment that doesn't find any visitors.
Added as many tests as I could. Noticed the MySQL version on Travis doesn't support this feature yet otherwise could have tested it there further.