Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mysql column type for new installs for log_action.name and log_conversion.url #14848

Merged
merged 1 commit into from Sep 3, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 3, 2019

from TEXT to VARCHAR
refs #14535

Already includes the update for Matomo 4.

This is part 1 for issue #14535 . The other PR needs to be created for Matomo 4 only as we can't change it for new installs but not for old installs: #14847

We're changing it for new installs already now as it saves us running an alter table on log_action later for heaps of installations. The less changes there will be later the better :)

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 3, 2019
@tsteur tsteur added this to the 3.12.0 milestone Sep 3, 2019
@diosmosis diosmosis merged commit bb145db into 3.x-dev Sep 3, 2019
@diosmosis diosmosis deleted the 14535_2 branch September 3, 2019 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants