Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid full table scans and log data purger #14839

Closed
tsteur opened this issue Sep 2, 2019 · 2 comments · Fixed by #14840
Closed

Avoid full table scans and log data purger #14839

tsteur opened this issue Sep 2, 2019 · 2 comments · Fixed by #14840
Assignees
@tsteur
Labels
c: Performance For when we could improve the performance / speed of Matomo.
Milestone
3.12.0

Comments

@tsteur
Copy link
Member

tsteur commented Sep 2, 2019

image

I'm not quite sure where this query comes from. At first I thought it is https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/PrivacyManager/LogDataPurger.php#L154-L162 but this query doesn't seem to be executed by a task and only in UI. Not sure where this query is from?
@tsteur tsteur added the c: Performance For when we could improve the performance / speed of Matomo. label Sep 2, 2019
@tsteur tsteur added this to the 3.12.0 milestone Sep 2, 2019
@tsteur
Copy link
Member Author

tsteur commented Sep 2, 2019

Maybe the query is from https://github.com/matomo-org/matomo/blob/3.12.0-b2/core/DataAccess/RawLogDao.php#L249-L269 ?

@tsteur
Copy link
Member Author

tsteur commented Sep 2, 2019

It probably be also good to launch this query on the reader, not the writer.

@tsteur tsteur self-assigned this Sep 2, 2019
@tsteur tsteur mentioned this issue Sep 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
c: Performance For when we could improve the performance / speed of Matomo.
Projects
None yet
Milestone
3.12.0
Development

Successfully merging a pull request may close this issue.

Make sure to use index on log table when deleting log entries matomo-org/matomo
1 participant
@tsteur