New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various platform tweaks #14832
Merged
Merged
Various platform tweaks #14832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
commented
Aug 28, 2019
mattab
reviewed
Sep 2, 2019
mattab
reviewed
Sep 2, 2019
diosmosis
reviewed
Sep 7, 2019
mattab
added
the
c: Platform
For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
label
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: Platform
For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Needs Review
PRs that need a code review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$matomoDir/bootstrap.php
like$GLOBALS['CONFIG_INI_PATH_RESOLVER'] = function () {return 'pathOutsideMatomo'};
misc/user
folder for GeoIP... this way you can have the geoIP DB outside a Matomo directory'Config.beforeSave'
see documentation to prevent saving some sensitive data in the config. It is also eg useful for https://github.com/matomo-org/plugin-EnvironmentVariables where you would want to prevent saving any potentially sensitive value to the database that is set through an environment variable. Say you set the database password through an environment variable, then you would want to prevent that the password is written to the config file next time the config is savedThese changes were needed for some new feature we're working on. Besides the config files and the new event we wouldn't document the other features I suppose. Could potentially add some tests for disable user/site admin but not sure if needed. Think we're not doing it so far for other areas? And it's quite straight forward but could add some if needed.