Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various platform tweaks #14832

Merged
merged 18 commits into from Sep 13, 2019
Merged

Various platform tweaks #14832

merged 18 commits into from Sep 13, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Aug 28, 2019

  • Let a user customise from where to load the config file by specifying a function in $matomoDir/bootstrap.php like $GLOBALS['CONFIG_INI_PATH_RESOLVER'] = function () {return 'pathOutsideMatomo'};
  • New config to disallow editing users (useful when syncing users)
  • New config to disallow editing sites (useful when syncing sites)
  • Configurable misc/user folder for GeoIP... this way you can have the geoIP DB outside a Matomo directory
  • A new event 'Config.beforeSave' see documentation to prevent saving some sensitive data in the config. It is also eg useful for https://github.com/matomo-org/plugin-EnvironmentVariables where you would want to prevent saving any potentially sensitive value to the database that is set through an environment variable. Say you set the database password through an environment variable, then you would want to prevent that the password is written to the config file next time the config is saved

These changes were needed for some new feature we're working on. Besides the config files and the new event we wouldn't document the other features I suppose. Could potentially add some tests for disable user/site admin but not sure if needed. Think we're not doing it so far for other areas? And it's quite straight forward but could add some if needed.

@tsteur tsteur added the Needs Review PRs that need a code review label Aug 28, 2019
@tsteur tsteur added this to the 3.12.0 milestone Aug 28, 2019
config/global.ini.php Outdated Show resolved Hide resolved
core/Config.php Outdated Show resolved Hide resolved
config/global.ini.php Outdated Show resolved Hide resolved
@diosmosis diosmosis merged commit eb135d8 into 3.x-dev Sep 13, 2019
@diosmosis diosmosis deleted the platformtweaks branch September 13, 2019 09:27
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants