Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When deleting a segment, do a soft delete instead of a hard delete #14826

Closed
tsteur opened this issue Aug 28, 2019 · 0 comments · Fixed by #14846
Closed

When deleting a segment, do a soft delete instead of a hard delete #14826

tsteur opened this issue Aug 28, 2019 · 0 comments · Fixed by #14846
Assignees
@katebutler
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
3.12.0

Comments

@tsteur
Copy link
Member

tsteur commented Aug 28, 2019

We already have a flag deleted in segments. When we delete a segment, it should actually keep the segment entry instead of deleting it fully. This allows us to better delete orphaned segments from archives etc. We should also updated the ts_last_edit in the segment table and set it to now() when soft deleting the segment.
@tsteur tsteur added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Aug 28, 2019
@tsteur tsteur added this to the 3.12.0 milestone Aug 28, 2019
@tsteur tsteur mentioned this issue Aug 28, 2019
Closed
@katebutler katebutler self-assigned this Sep 2, 2019
@katebutler katebutler mentioned this issue Sep 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katebutler katebutler

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
3.12.0
Development

Successfully merging a pull request may close this issue.

Soft delete segments matomo-org/matomo
2 participants
@tsteur @katebutler