@Findus23 opened this Pull Request on August 28th 2019 Member

related to https://github.com/matomo-org/matomo/issues/14821
With PHP 7.4 a lot of incorrect usages of functions have been deprecated.
One of them is that implode() will now throw a warning if the glue isn't the first parameter.

I'll update this PR as I come across more warnings.

@tsteur commented on August 28th 2019 Member

I'd be happy to merge. Not sure why PR is in draft maybe you want to make more changes?

@Findus23 commented on August 28th 2019 Member

@tsteur When I made the PR I expected there to be many of those cases, but it turns out that this seems to be the only one.
So I guess this can be merged.

This Pull Request was closed on August 28th 2019
Powered by GitHub Issue Mirror