Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct NotYetInstalledException when Matomo is not yet installed #14823

Merged
merged 1 commit into from Sep 18, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Aug 28, 2019

Otherwise it can become impossible to catch this exception.

@tsteur tsteur added the Needs Review PRs that need a code review label Aug 28, 2019
@tsteur tsteur added this to the 3.12.0 milestone Aug 28, 2019
@diosmosis diosmosis merged commit 782768d into 3.x-dev Sep 18, 2019
@diosmosis diosmosis deleted the notyetinstalledexception branch September 18, 2019 01:27
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants