Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Matomo compatible with PHP 7.4 #14821

Closed
Findus23 opened this issue Aug 27, 2019 · 9 comments · Fixed by #15180
Closed

Make Matomo compatible with PHP 7.4 #14821

Findus23 opened this issue Aug 27, 2019 · 9 comments · Fixed by #15180
Assignees
@diosmosis
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
3.13.0

Comments

@Findus23
Copy link
Member

Findus23 commented Aug 27, 2019 •
edited

similar to #13418

Status:

All Warnings in Matomo itself and the broken Twig rendering are fixed in Matomo 3.12. All remaining warnings depend on third-party libraries (see below).

Soon PHP 7.4 will be released (RC 1 is planned or September 5th), so it would be great if Matomo would work mostly fine when it is released.

I set up a Matomo instance using the latest beta4 at https://matomo-beta.lw1.at
If you want to get access, just message me.

Current status is that Matomo is nearly completly unusable as it renders invalid HTML with missing whitespaces:

<ul class="right hide-on-med-and-down"><li role="menuitem" class="active"><atitle="Zeige Webanalytik Berichte für Testsite."                  id="topmenu-corehome"
                  href="index.php?module=CoreHome&amp;action=index&amp;idSite=1&amp;period=day&amp;date=yesterday"               target="_self" tabindex="3">Dashboard</a></li><li role="menuitem" class=""><atitle="Vergleichen Sie Webanalytikstatistiken für alle Ihre Websites."                  id="topmenu-multisites"
                  href="index.php?module=MultiSites&amp;action=index&amp;idSite=1&amp;period=day&amp;date=yesterday"               target="_self" tabindex="3">Alle Websites</a></li><li role="menuitem" class=""><atitle=""                  id="topmenu-tagmanager"

This seem to be caused by a required change in Twig (twigphp/Twig@1fb0f97), so updating to twig 1.41.0 or later should solve this.
@Findus23 Findus23 added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Aug 27, 2019
This was referenced Aug 28, 2019
Merged
Closed
@Findus23
Copy link
Member Author

Findus23 commented Aug 28, 2019 •
edited

One more bug that breaks archiving: (appears as a response in archiving)

PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /var/www/matomo-beta/libs/upgradephp/upgrade.php on line 180 PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /var/www/matomo-beta/libs/upgradephp/upgrade.php on line 194 PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /var/www/matomo-beta/libs/upgradephp/upgrade.php on line 194 PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /var/www/matomo-beta/libs/upgradephp/upgrade.php on line 200 PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /var/www/matomo-beta/libs/upgradephp/upgrade.php on line 202

matomo/libs/upgradephp/upgrade.php

Line 180 in 7ef8926

if ($line{0} == '[') {

I don't know what that line means, but I am also confused why this function is here when Matomo is using a custom ini parser.

Update: It seems to just be a weird way of writing if ($line[0] == '[') {

@Findus23 Findus23 mentioned this issue Aug 28, 2019
Merged
@Findus23
Copy link
Member Author

One more warning in the log:

/var/www/matomo-beta/core/DataTable/Filter/ColumnDelete.php(164): Deprecated - array_key_exists(): Using array_key_exists() on objects is deprecated. Use isset() or property_exists() instead - Matomo 3.11.0

matomo/core/DataTable/Filter/ColumnDelete.php

Line 164 in b16a791

if (!array_key_exists($column, $row)) {

@Findus23 Findus23 mentioned this issue Aug 28, 2019
Merged
@Findus23
Copy link
Member Author

Findus23 commented Aug 28, 2019 •
edited

Another occurrence of the braces will be fixed with leafo/lessphp#647 (if it gets merged as the last release was 5 years ago)

Update: This one is going to be fun to fix as the latest lessphp requires PHP 5.6+: leafo/lessphp@18b8f29

@Findus23
Copy link
Member Author

Two more deprecation warnings in tcpdf will be fixed with
tecnickcom/TCPDF#123
and
tecnickcom/TCPDF#131

@Findus23
Copy link
Member Author

Another potential bug (but I don't think it happens in Matomo and is only very minor):
davaxi/Sparkline#10

@Findus23 Findus23 mentioned this issue Aug 28, 2019
Merged
This was referenced Sep 8, 2019
Merged
Merged
@mattab mattab added this to the 3.13.0 milestone Oct 25, 2019
@mattab
Copy link
Member

mattab commented Oct 27, 2019

@Findus23 Thanks for creating the issue! 👍 What is the status of PHP 7.4 compatibility now?

@Findus23
Copy link
Member Author

@mattab I think all remaining issues are in third party libraries as mentioned above. And Matomo won't be completly ususable as of now.
But I don't have a great solution for updating those.

@diosmosis diosmosis mentioned this issue Nov 12, 2019
Merged
@diosmosis
Copy link
Member

Looks like the only package that needs to be updated is lessphp, but that does not have a release w/ the fix. I suppose we could fork it as well or wait until matomo 4.

@tsteur
Copy link
Member

tsteur commented Nov 19, 2019

We'd need to fork it in this case since we can't wait to Matomo 4 unfortunately.

@diosmosis diosmosis self-assigned this Nov 20, 2019
@diosmosis diosmosis mentioned this issue Nov 21, 2019
Merged
@Findus23 Findus23 mentioned this issue Dec 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
3.13.0
Development

Successfully merging a pull request may close this issue.

Update lessphp to use branch for php 7.4 compatibility. matomo-org/matomo
4 participants
@diosmosis @tsteur @mattab @Findus23