Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer require idsite in addtracker #14787

Merged
merged 5 commits into from Aug 26, 2019
Merged

No longer require idsite in addtracker #14787

merged 5 commits into from Aug 26, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Aug 18, 2019

fix #14781

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Aug 18, 2019
@tsteur tsteur added this to the 3.12.0 milestone Aug 18, 2019
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess the failing JS tests need to be fixed in TagManager: https://travis-ci.org/matomo-org/matomo/jobs/573555566#L750
Otherwise looks good to merge.

@tsteur tsteur merged commit f668800 into 3.x-dev Aug 26, 2019
@tsteur tsteur deleted the 14781 branch August 26, 2019 01:52
@Asjenw
Copy link

Asjenw commented Sep 17, 2019

@sgiehl @tsteur When is this planned to be released? We constantly get errors at our website, probably because of this issue. I saw the release date being changed from 4-9 into 15-10, is that the definitive date or is it likely to change again?

@tsteur
Copy link
Member Author

tsteur commented Sep 17, 2019

It will be included in the next release. The current beta already includes this change I think

@Asjenw
Copy link

Asjenw commented Sep 18, 2019 via email

@tsteur
Copy link
Member Author

tsteur commented Sep 18, 2019

@Asjenw
Copy link

Asjenw commented Sep 25, 2019 via email

@tsteur
Copy link
Member Author

tsteur commented Sep 25, 2019

@Asjenw we will update it there for you likely in the next 24-48 hours. When you have such issues on cloud simply get in touch with our support by mail: support at matomo.cloud

@Asjenw
Copy link

Asjenw commented Sep 25, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaScript tracker: change Piwik.addTracker() to allow not setting an idSite
3 participants