@tsteur opened this Pull Request on August 18th 2019 Member

refs https://github.com/matomo-org/matomo/pull/14761

Avoids generating queries like this:

CREATE TEMPORARY TABLE IF NOT EXISTS logtmpsegmente5bfbc1f135a495c4f5aad6d8047199c (idvisit  BIGINT(10) UNSIGNED NOT NULL) 
            SELECT
                distinct log_inner.idvisit as idvisit
            FROM

        (

            SELECT
                log_visit.idvisit
            FROM
                log_visit AS log_visit LEFT JOIN log_link_visit_action AS log_link_visit_action ON log_link_visit_action.idvisit = log_visit.idvisit
            WHERE
                ( log_visit.visit_last_action_time >= '2019-04-30 14:00:00'
                AND log_visit.visit_last_action_time <= '2019-05-31 13:59:59'
                AND log_visit.idsite IN ('1') )
                AND
                ( ( log_link_visit_action.idaction_url IN (SELECT idaction FROM log_action WHERE ( name LIKE CONCAT('%', '/admin', '%')  AND type = 1 )) ) )
            GROUP BY
                log_visit.idvisit
            ORDER BY
                NULL
        ) AS log_inner
            ORDER BY
                log_inner.idvisit ASC

where we don't need the subquery anymore for create temp table statements anymore as we always do a distinct idvisit anyway.

Also fixes an issue where the bind was wrongly set for roll up reporting

This Pull Request was closed on September 18th 2019
Powered by GitHub Issue Mirror