Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate/remove segment query cache (filter logic) #14776

Open
tsteur opened this issue Aug 15, 2019 · 6 comments
Open

Deprecate/remove segment query cache (filter logic) #14776

tsteur opened this issue Aug 15, 2019 · 6 comments
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Aug 15, 2019

In #14761 we fixed #11900 where we make segments behave the way it actually should be and how you want it to work in most cases.

We're unsure yet if this is supported by all MySQL versions etc and want to see general user feedback about this. People can currently restore the old behaviour easily by setting [General]enable_segments_cache = 0 if there are any problems with MySQL.

In a few cases it may behave differently before where you want to use it kind of as a raw data filter on a given report. For example you want to filter pageloadtime>=1s then you would maybe only want to see the pages that took longer than 1s to load and see how often it took longer to load than 1s. It wouldn't be a filter on the data table (like GA does it) but a raw data filter. If someone still wanted this behaviour after Matomo 4, a workaround be to use CustomReports.

Eventually, in Matomo 4, we will want to no longer have it possible to restore the old behaviour by disabling above config but always apply it if it's supported by most MySQL versions as this is the way segments are supposed to work.

A different feature that is filtering on the data table, not raw data be #11931 which we may want to consider in the future.

@tsteur tsteur added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Aug 15, 2019
@tsteur tsteur added this to the 4.0.0 milestone Aug 15, 2019
@sgiehl
Copy link
Member

sgiehl commented Feb 12, 2020

@tsteur Do we still consider removing the old behavior config flag? Otherwise guess we can close or move that to a later milestone

it's also related to #15438

@tsteur tsteur modified the milestones: 4.0.0, 5.0.0 Feb 12, 2020
@tsteur
Copy link
Member Author

tsteur commented Feb 12, 2020

I would say let's keep the flag in there until Matomo 5.

@tsteur
Copy link
Member Author

tsteur commented Feb 12, 2020

Moved it to 5.0.0

@tsteur tsteur changed the title Matomo 4: Deprecate/remove segment query cache (filter logic) Feb 12, 2020
@mattab
Copy link
Member

mattab commented Dec 11, 2023

Maybe this has been completed in Matomo 5?

@sgiehl
Copy link
Member

sgiehl commented Dec 11, 2023

No. The config enable_segments_cache is still available.

@tsteur
Copy link
Member Author

tsteur commented Dec 18, 2023

Note that unless we have added the filter feature #11931 by then, we might still want to keep this setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Projects
None yet
Development

No branches or pull requests

3 participants