Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not record the stack trace for user input errors #14771

Merged
merged 1 commit into from Aug 16, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Aug 15, 2019

As the logs are otherwise full of them as they are happening thousands of times every hour and it is quite clear where these errors are happening etc.

This lets you better find actual errors.

@tsteur tsteur added the Needs Review PRs that need a code review label Aug 15, 2019
@tsteur tsteur added this to the 3.12.0 milestone Aug 15, 2019
@diosmosis diosmosis merged commit 0ced138 into 3.x-dev Aug 16, 2019
@diosmosis diosmosis deleted the exceptionhandling branch August 16, 2019 01:39
tsteur added a commit that referenced this pull request Feb 16, 2020
Follow up from #14771

Have been debugging and the above PR alone did not help since the `PsrLogMessageProcessor` would call the toString method of the exception and add the message again. This makes sure the logs are more readble.
sgiehl pushed a commit that referenced this pull request Feb 17, 2020
Follow up from #14771

Have been debugging and the above PR alone did not help since the `PsrLogMessageProcessor` would call the toString method of the exception and add the message again. This makes sure the logs are more readble.
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
Follow up from matomo-org#14771

Have been debugging and the above PR alone did not help since the `PsrLogMessageProcessor` would call the toString method of the exception and add the message again. This makes sure the logs are more readble.
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
Follow up from matomo-org#14771

Have been debugging and the above PR alone did not help since the `PsrLogMessageProcessor` would call the toString method of the exception and add the message again. This makes sure the logs are more readble.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants