Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Overlay stuck on "Loading..." #14764

Closed
Findus23 opened this issue Aug 13, 2019 · 18 comments
Closed

Page Overlay stuck on "Loading..." #14764

Findus23 opened this issue Aug 13, 2019 · 18 comments
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone

Comments

@Findus23
Copy link
Member

very similar to #11768
not like #12815 (no error or failed request)

Not sure since when, but the page overlay doesn't really seem to work anymore.
It only shows the loading screen but doesn't actually do anything:
image
There are no errors in the console, no failed HTTP requests and not even any HTTP requests apart from the assets of the page (so no calls to the API)

This can also be reproduced on demo.matomo.org

and has been reported on the forum:
https://forum.matomo.org/t/page-overlay-fehler/33851

@Findus23 Findus23 added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Aug 13, 2019
@peterbo
Copy link
Contributor

peterbo commented Aug 14, 2019

Same here, tested on 3 different instances (MTM 3.11)

@tsteur
Copy link
Member

tsteur commented Aug 14, 2019

This should have been fixed in #14766

@tsteur tsteur closed this as completed Aug 14, 2019
@peterbo
Copy link
Contributor

peterbo commented Aug 14, 2019

Fix works, thanks, Thomas!

@mattab mattab added this to the 3.12.0 milestone Oct 27, 2019
@tiptronic85
Copy link

I had the same issue, i upgraded to 3.13.1 version, and now i'm getting logged out.
Anyone with this problem?

@polarbirke
Copy link
Contributor

I'm seeing the exact same failing behaviour with 3.13.2 in latest Firefox and latest Chrome for several of our websites:

  • loading spinner shown, but nothing happens
  • no errors in the console
  • no failed HTTP requests

I've seen this happen before (August 2019) and I know the fix worked, because the Page Overlay was working fine in November 2019. Could this be another regression?

@chrisprog20
Copy link

@polarbirke: Maybe you try the newest version 3.13.3. There the page overlay works - even in Firefox.
But: I cannot login with the App "Internet Explorer 11" in Windows 10 (with 3.13.3). I then get the following error message: "Error: Your session has expired due to inactivity. Please login to continue."
But if I try to login in with other browsers (I tested it with Chrome, Firefox, Edge) I can log in.

@polarbirke
Copy link
Contributor

Thanks @chrisprog20! Unfortunately I cannot confirm that, I still have the same endless loading spinner without errors with 3.13.3 😞

@tsteur tsteur modified the milestones: 3.12.0, 3.13.4 Feb 25, 2020
@tsteur
Copy link
Member

tsteur commented Feb 25, 2020

I'll reopen it for now @polarbirke can you confirm this used to work in an older version? Would it be possible to get access to your Matomo? If so, please comment here and send us the details to hello at matomo dot org. A user with view access be enough.

@tsteur tsteur reopened this Feb 25, 2020
@polarbirke
Copy link
Contributor

Thank you @tsteur! I can confirm that it was working in November 2019 after a period where I saw the same issue occur in August 2019. I do not remember the relevant version numbers.

I have added a user called "matomo-support" with the mail address you provided and access to Matomo for our company website. I have confirmed just now that the page overlay does still not load for the homepage ('/').

@chrisprog20
Copy link

@polarbirke: Oh, ok! Great that @tsteur helps you! :)

@tsteur
Copy link
Member

tsteur commented Feb 27, 2020

BTW when viewing overlay, make sure to disable any active ad blocker or similar.

Thanks for sending the login details btw. Could someone apply these 2 minor changes and see if it helps? https://github.com/matomo-org/matomo/compare/3.x-dev...issue_14764?quick_pull=1

It seems we're still sending the strict referrer policy there.

@polarbirke
Copy link
Contributor

Could someone apply these 2 minor changes and see if it helps? https://github.com/matomo-org/matomo/compare/3.x-dev...issue_14764?quick_pull=1

Hej Thomas, thanks for looking into it. Was the above intended for me? 🤔

@chrisprog20
Copy link

chrisprog20 commented Feb 27, 2020

@polarbirke: I do not know if Thomas' message was directed to you but if you try his fix in https://github.com/matomo-org/matomo/compare/3.x-dev...issue_14764?quick_pull=1 in your matomo installation you can test if it solves your problem :-)

@sgiehl
Copy link
Member

sgiehl commented Mar 5, 2020

@polarbirke were you able to apply the changes and check if that fixes your issue with the Overlay?

@chrisprog20 your login issue with IE 11 will be fixed with #15633

@polarbirke
Copy link
Contributor

Hi folks,

we applied the patch to our installation today and it did not fix the issue – HOWEVER @tsteur was on exactly the right track, only it was us, not you. 👀

Our DevOps had decided to hardwire referrer-policy: strict-origin in Apache for all our servers, including our Matomo instance. We've relaxed that with setifempty now, so Matomo's same-origin header is not overwritten.

Thank you all for your generous support and apologies for making our problem your problem! 🙏

/cc @chrisprog20 @sgiehl

@polarbirke
Copy link
Contributor

Addendum: if we want to use setifempty it's imperative that Matomo always sets a header – currently you're setting a strict policy or none. I've proposed an update in #15673 if you want to be explicit about your headers and indulge our way of working. 🙌

@tsteur
Copy link
Member

tsteur commented Mar 15, 2020

PR was merged so marking it as closed for now. Thanks @polarbirke

@tsteur tsteur closed this as completed Mar 15, 2020
@polarbirke
Copy link
Contributor

Thank you, @tsteur! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

No branches or pull requests

8 participants