Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves keyboard navigation for segment editor #14757

Merged
merged 3 commits into from Aug 19, 2019
Merged

Improves keyboard navigation for segment editor #14757

merged 3 commits into from Aug 19, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 12, 2019 •
edited

Pressing enter should now work. Additionally the segments in the list, will be highlighted when focus with tab (not in IE, as it doesn't support :focus-within) and the "All visits" segment is now selectable using tab as well.

tested the changes in Chrome, Firefox and IE

fixes #14755

@sgiehl sgiehl added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). labels Aug 12, 2019
@mattab mattab added this to the 3.12.0 milestone Aug 13, 2019
@tsteur tsteur merged commit e2679a3 into 3.x-dev Aug 19, 2019
@tsteur tsteur deleted the segmenteditorux branch August 19, 2019 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). c: Design / UI For issues that impact Matomo's user interface or the design overall. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

Pressing "Enter" key does not work to apply a Segment using Keyboard
3 participants
@sgiehl @tsteur @mattab