Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some debugging info to log notifications so they can be more easily reproduced. #14753

Merged
merged 2 commits into from Aug 17, 2019
Merged

Add some debugging info to log notifications so they can be more easily reproduced. #14753

merged 2 commits into from Aug 17, 2019

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Aug 11, 2019 •
edited

No description provided.

@diosmosis diosmosis added the Needs Review PRs that need a code review label Aug 11, 2019
@diosmosis diosmosis added this to the 3.12.0 milestone Aug 11, 2019
@diosmosis
Copy link
Member Author

Updated.

@tsteur
Copy link
Member

tsteur commented Aug 16, 2019

Haven't tested it but looks good @diosmosis can you just check it escapes things before merging?

@diosmosis
Copy link
Member Author

Verified the notification escapes the content before displaying; adding <script>alert(1);</script> did not create an alert.

@diosmosis diosmosis merged commit 9f6197a into 3.x-dev Aug 17, 2019
@diosmosis diosmosis deleted the web-notification-debug branch August 17, 2019 02:27
@mattab mattab added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @tsteur @mattab