Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure test constant exists in feedback #14737

Merged
merged 1 commit into from Aug 9, 2019
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Aug 7, 2019

Not quite sure how this did not fail earlier or how this usually works but seeing an error around this in my logs:

www/piwik/plugins/Feedback/Feedback.php(117): Notice - Use of undefined constant PIWIK_TEST_MODE - assumed 'PIWIK_TEST_MODE' - Matomo 3.12.0-b1 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already)

Not quite sure how this did not fail earlier or how this usually works but seeing an error around this in my logs:

> www/piwik/plugins/Feedback/Feedback.php(117): Notice - Use of undefined constant PIWIK_TEST_MODE - assumed 'PIWIK_TEST_MODE' - Matomo 3.12.0-b1 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already)
@tsteur tsteur added the Needs Review PRs that need a code review label Aug 7, 2019
@tsteur tsteur added this to the 3.12.0 milestone Aug 7, 2019
@sgiehl sgiehl merged commit 3133182 into 3.x-dev Aug 9, 2019
@sgiehl sgiehl deleted the piwiktestmodefeedback branch August 9, 2019 07:48
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants