Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid warning from passing 2 args to ucwords() on older PHP versions #14734

Merged
merged 2 commits into from Aug 6, 2019
Merged

Avoid warning from passing 2 args to ucwords() on older PHP versions #14734

merged 2 commits into from Aug 6, 2019

Conversation

katebutler
Copy link

Fixes #14694

@katebutler katebutler added the Needs Review PRs that need a code review label Aug 6, 2019
@katebutler katebutler added this to the 3.12.0 milestone Aug 6, 2019
@diosmosis diosmosis merged commit f1900e7 into 3.x-dev Aug 6, 2019
@diosmosis diosmosis deleted the 14694 branch August 6, 2019 19:44
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 25, 2019
sgiehl pushed a commit that referenced this pull request Mar 2, 2020
@sgiehl
Avoid warning from passing 2 args to ucwords() on older PHP versions (#…
54c3855 
…14734)

* Don't use ucwords on older versions of PHP

* Add comment
diosmosis added a commit that referenced this pull request Mar 5, 2020
@diosmosis
Avoid warning from passing 2 args to ucwords() on older PHP versions (#…
0fd0b30 
…14734) (#15650)

* Don't use ucwords on older versions of PHP

* Add comment

Co-authored-by: Kate Butler <kate@innocraft.com>
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
@diosmosis @jonasgrilleres
Avoid warning from passing 2 args to ucwords() on older PHP versions (m…
8405a87 
…atomo-org#14734) (matomo-org#15650)

* Don't use ucwords on older versions of PHP

* Add comment

Co-authored-by: Kate Butler <kate@innocraft.com>
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
@diosmosis @jbuget
Avoid warning from passing 2 args to ucwords() on older PHP versions (m…
a11f584 
…atomo-org#14734) (matomo-org#15650)

* Don't use ucwords on older versions of PHP

* Add comment

Co-authored-by: Kate Butler <kate@innocraft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

Warning - ucwords() expects exactly 1 parameter, 2 given
3 participants
@katebutler @diosmosis @mattab