Two small changes for GA importer #14727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
diosmosis
commented
Aug 2, 2019
diosmosis
commented
- Add Visualization.beforeRender event. I need to add a footer message after the datatable is loaded, so I can't use VIewDataTable.configure (since it's posted in the constructor).
- Don't overwrite existing table metadata entries when loading datatables from blobs so metadata that is archived is returned through the API.
…nstead of overwriting everything.
diosmosis
added
not-in-changelog
tsteur
reviewed
Aug 3, 2019
core/Plugin/Visualization.php
Outdated
| private function fireBeforeRenderHook() | ||
| { | ||
| /** | ||
| * @ignore |
There was a problem hiding this comment.
Could we make this an official event and add a small description?
|
LGTM... be just good to add some comment for the event |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.