Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preventing scrollbars from showing up when embedding reports via iframe #14724

Merged
merged 4 commits into from Aug 4, 2019
Merged

Preventing scrollbars from showing up when embedding reports via iframe #14724

merged 4 commits into from Aug 4, 2019

Conversation

skerbis
Copy link
Contributor

@skerbis skerbis commented Aug 2, 2019

fixes: #14716
Thanks to: @tsteur for helping

I've tested it, it works nice

Greetings from @FriendsOfREDAXO

@skerbis skerbis mentioned this pull request Aug 2, 2019
Closed
@tsteur
Mention iframe resizer in the legal notice
a69648f 
Was forgotten to be added there previously
@tsteur
Copy link
Member

tsteur commented Aug 4, 2019

FYI: Documented this new behaviour here: https://matomo.org/docs/embed-matomo-reports/#preventing-scrollbars-from-showing-up

@skerbis
Copy link
Contributor Author

skerbis commented Aug 4, 2019

Perfect thx

@tsteur tsteur merged commit 6a6af0c into matomo-org:3.x-dev Aug 4, 2019
@tsteur
Copy link
Member

tsteur commented Aug 4, 2019

Cheers @skerbis

@mattab mattab changed the title Adds the newest iframeSizer.min.js and …contentWindow.js Preventing scrollbars from showing up when embedding reports via iframe Oct 25, 2019
@mattab mattab added c: Design / UI For issues that impact Matomo's user interface or the design overall. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. labels Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

embed dashboard iframe auto-height
3 participants
@skerbis @tsteur @mattab