When loading templates detect if an ad blocker is active #14722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix DEV-1680 The status seems to be -1 when an ad blocker is blocking the loading of an html template (eg HeatmapSessionRecording)
diosmosis
reviewed
Aug 4, 2019
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| function isClientError(rejection) | |||
| { | |||
| if (rejection.status === 500) { | |||
| if (rejection.status === 500 || rejection.status === -1) { | |||
There was a problem hiding this comment.
Can we do <= 0 to potentially catch more problems?
There was a problem hiding this comment.
Done. Although not sure when it would be 0 or lower than that but we can always change it again later if needed for some reason 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix DEV-1680
The status seems to be -1 when an ad blocker is blocking the loading of an html template (eg HeatmapSessionRecording)
Should avoid error like this: