Do not cache error page #14718
Merged
Do not cache error page #14718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs DEV-1725 Ensuring that when the page is reloaded, it will be fetched again.
diosmosis
reviewed
Aug 1, 2019
| @@ -116,6 +116,7 @@ function Piwik_GetErrorMessagePage($message, $optionalTrace = false, $optionalLi | |||
|
|
|||
| if (!headers_sent()) { | |||
| header('Content-Type: text/html; charset=utf-8'); | |||
| header('Cache-Control: private, no-cache, no-store'); | |||
There was a problem hiding this comment.
Is there a reason for using multiple cacheability directives? Seems like we'd only need to use no-store (from reading https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#Cacheability).
There was a problem hiding this comment.
@diosmosis that's what we also use in production see eg https://stackoverflow.com/a/2068407/1447375 . In this case we don't set the Expires or Pragma no-cache but at least the Cache-Control.
There was a problem hiding this comment.
I see it's for different browsers. Fun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs DEV-1725
Ensuring that when the page is reloaded, it will be fetched again.