Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds command to update iso region names #14712

Merged
merged 4 commits into from Jul 31, 2019
Merged

Adds command to update iso region names #14712

merged 4 commits into from Jul 31, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 30, 2019

and updates region names.

fixes #14462

@sgiehl sgiehl added Needs Review PRs that need a code review c: i18n For issues around internationalisation and localisation. labels Jul 30, 2019
@sgiehl sgiehl added this to the 3.12.0 milestone Jul 30, 2019
@tsteur
Copy link
Member

tsteur commented Jul 30, 2019

Haven't tested it but code looks 👍

@sgiehl sgiehl merged commit 32f8ba7 into 3.x-dev Jul 31, 2019
@sgiehl sgiehl deleted the updateisoregions branch July 31, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

Assignees
No one assigned
Labels
c: i18n For issues around internationalisation and localisation. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

Cities do not correspond to regions
2 participants
@sgiehl @tsteur