Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send 403 header on failed Login #14708

Merged
merged 2 commits into from Aug 4, 2019
Merged

Send 403 header on failed Login #14708

merged 2 commits into from Aug 4, 2019

Conversation

pebosi
Copy link
Contributor

@pebosi pebosi commented Jul 29, 2019

Proposal for #14085

@Findus23
Copy link
Member

Hi,

Thanks for the PR.
I don't think you can assume everyone is using HTTP 1.0.
Thankfully since PHP 5.4 there is a function for this: http_response_code().

@Findus23
Copy link
Member

Or maybe use the exiting helper function:

public static function sendResponseCode($code)

@tsteur Is there any reason why there is a custom function?

@tsteur
Copy link
Member

tsteur commented Jul 29, 2019

Looking at the content of the method it definitely seems like there's a reason fir it by the looks. But maybe http_response_code() was never used and that's why it was needed. Not sure.

Use http_response_code
@pebosi
Copy link
Contributor Author

pebosi commented Jul 30, 2019

Changed to use http_response_code

@diosmosis
Copy link
Member

Works for me, thanks for the contribution @pebosi!

@diosmosis diosmosis merged commit 7f61f6b into matomo-org:3.x-dev Aug 4, 2019
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants