@pebosi opened this Pull Request on July 29th 2019 Contributor

Proposal for #14085

@Findus23 commented on July 29th 2019 Member

Hi,

Thanks for the PR.
I don't think you can assume everyone is using HTTP 1.0.
Thankfully since PHP 5.4 there is a function for this: http_response_code().

@Findus23 commented on July 29th 2019 Member

Or maybe use the exiting helper function:
https://github.com/matomo-org/matomo/blob/65b5523adf92c686f1448e858fa428b57d68a674/core/Common.php#L1196

@tsteur Is there any reason why there is a custom function?

@tsteur commented on July 29th 2019 Member

Looking at the content of the method it definitely seems like there's a reason fir it by the looks. But maybe http_response_code() was never used and that's why it was needed. Not sure.

@pebosi commented on July 30th 2019 Contributor

Changed to use http_response_code

@diosmosis commented on August 4th 2019 Member

Works for me, thanks for the contribution @pebosi!

This Pull Request was closed on August 4th 2019
Powered by GitHub Issue Mirror