Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visitor Log fetches always one entry too much #14701

Open
tsteur opened this issue Jul 26, 2019 · 0 comments
Open

Visitor Log fetches always one entry too much #14701

tsteur opened this issue Jul 26, 2019 · 0 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Data Integrity & Accuracy

Comments

@tsteur
Copy link
Member

tsteur commented Jul 26, 2019

To reproduce set your limit in the visitor log eg to 5 and then click on the next page. You will see in the Live model method when it fetches the data that it will be actually fetching 7 entries.

It does a $limit + 1 here: https://github.com/matomo-org/matomo/blob/3.11.0/plugins/Live/Visualizations/VisitorLog.php#L57

and then another +1 here: https://github.com/matomo-org/matomo/blob/3.11.0/plugins/Live/Model.php#L43

This way you might skip in the end a visitor? Anyway, it should only do one of the plus ones. Probably the one in the visualisation can be simply removed.

@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Jul 26, 2019
@mattab mattab added this to the 4.2.0 milestone Jan 21, 2020
@matomo-org matomo-org deleted a comment from c-prompt Dec 11, 2023
@matomo-org matomo-org deleted a comment from tsteur Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Data Integrity & Accuracy
Projects
None yet
Development

No branches or pull requests

2 participants