New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning - ucwords() expects exactly 1 parameter, 2 given #14694
Comments
We will need to detect the PHP version and change logic based on this. I would say in PHP.5.5.9-PHP 5.5.15 we can simply not include the ucwords and assume user is not using curl2? Could also just explode instead and run strtoupper and all elements and then implode again... |
Disabling the fix in #14449 for the affected PHP versions sounds fine to me. No one apart from me even reported the original issue and as you say an ancient PHP version in combination with a really new curl version would be odd. |
Well done, but I wonder why this patch is not in the current 3.13.3 release? |
actually it should be included. But @sommer-gei which php version are you using and which error do you still get? 🤔 |
@sgiehl: Same error as in the issue title "Warning - ucwords() expects exactly 1 parameter, 2 given" with PHP 5.5.9 (yes I know it’s old). Thanks for your Feedback! |
Yeah you're right. That has been remove again in #14877 |
cc @tsteur not sure if this was due to a code merge issue or if there was a reason to remove it? |
Probably some github merge issue. We've had it a few times that suddenly some commit magically disappeared. Be good to add it again |
reported in https://forum.matomo.org/t/warning-messages-ucwords-expects-exactly-1-parameter-after-update-to-3-11-0/33611
introduced in #14449
matomo/core/Http.php
Line 868 in e236d14
It seems like the second parameter has only been introduced in PHP 5.5.16, but Matomo supports (I think 5.5.9+)
https://3v4l.org/Uf3Ya
https://stackoverflow.com/questions/42575390/is-ucwords-delimiter-parameter-supported-in-php-5-6
The text was updated successfully, but these errors were encountered: