Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show feedback prompt when user does not exist #14692

Merged
merged 1 commit into from Jul 25, 2019
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 24, 2019

Prevents an error in the UI that said

Date format must be: YYYY-MM-DD, or 'today' or 'yesterday' or any keyword supported by the strtotime function (see http://php.net/strtotime for more information):

when the user did not exist. Eg when you have "virtual" users that aren't actually existing in the user table.

Prevents an error in the UI that said

```
Date format must be: YYYY-MM-DD, or 'today' or 'yesterday' or any keyword supported by the strtotime function (see http://php.net/strtotime for more information):
``` 

when the user did not exist. Eg when you have "virtual" users that aren't actually existing in the user table.
@tsteur tsteur added the Needs Review PRs that need a code review label Jul 24, 2019
@tsteur tsteur modified the milestones: 3.11.0, 3.12.0 Jul 24, 2019
@sgiehl sgiehl merged commit ca056c4 into 3.x-dev Jul 25, 2019
@sgiehl sgiehl deleted the fixdateinvalid branch July 25, 2019 13:39
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants