Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick links widget #14689

Merged
merged 7 commits into from Aug 5, 2019
Merged

Quick links widget #14689

merged 7 commits into from Aug 5, 2019

Conversation

katebutler
Copy link

Fixes #13979

@katebutler katebutler added the Needs Review PRs that need a code review label Jul 22, 2019
@katebutler katebutler added this to the 3.11.0 milestone Jul 22, 2019
@mattab mattab modified the milestones: 3.11.0, 3.12.0 Jul 23, 2019
@tsteur
Copy link
Member

tsteur commented Jul 29, 2019

@katebutler similar to the system summary might be good to show icons in front of the links and not have a newline in between.

In general it's starting to get a bit busy in there:
image

I wonder if it makes sense to show the "Quick Links" above "System Summary"? They should be more important I suppose. Was thinking it be nice to merge eg Quick Links and System Summary but we disable different widgets on the cloud so that wouldn't be straight forward.

I was thinking maybe we could also add a link to "Add a goal" etc but these are not quite administrative and can be found in the reporting UI fairly easily anyway. So good not to bloat the widget. Most important is certainly "Add a new website" so users discover they can track more of them in one Matomo.

Maybe for now we leave it with those 2 links and over time at more links that make sense 👍

Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment


public function render()
{
return $this->renderTemplate('quickLinks');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here in render() we might need to add another Piwik::checkUserHasSuperUserAccess() just to be safe

@tsteur tsteur merged commit 1aefe69 into 3.x-dev Aug 5, 2019
@tsteur tsteur deleted the 13979 branch August 5, 2019 03:20
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shortcuts to admin homepage
3 participants