Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates npm dependencies for screenshot testing #14680

Merged
merged 6 commits into from Jul 25, 2019
Merged

Updates npm dependencies for screenshot testing #14680

merged 6 commits into from Jul 25, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 21, 2019 •
edited

Due to an update of chrome almost all screenshots needed an update because of slightly changes in the font rendering.

Maybe this improves the ui test stability a bit.

@sgiehl sgiehl added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Jul 21, 2019
@sgiehl sgiehl force-pushed the updateuideps branch 6 times, most recently from 0a9c649 to dfb545b Compare July 22, 2019 14:38
@sgiehl
Copy link
Member Author

sgiehl commented Jul 22, 2019

All failing UI tests should now be fixed. But there are still some randomly failing tests

@sgiehl sgiehl added this to the 3.11.0 milestone Jul 22, 2019
@sgiehl sgiehl added the Needs Review PRs that need a code review label Jul 22, 2019
@mattab mattab modified the milestones: 3.11.0, 3.12.0 Jul 23, 2019
@sgiehl
Copy link
Member Author

sgiehl commented Jul 25, 2019

Will merge that now, as the build is finally green 🎉

@sgiehl sgiehl merged commit 3e80d94 into 3.x-dev Jul 25, 2019
@sgiehl sgiehl deleted the updateuideps branch July 25, 2019 13:38
@sgiehl sgiehl mentioned this pull request Aug 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @mattab