Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show row actions no matter how many results in the data table are shown #14675

Merged
merged 1 commit into from Aug 1, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 18, 2019

refs #14418

@tsteur tsteur added the Needs Review PRs that need a code review label Jul 18, 2019
@tsteur tsteur added this to the 3.11.0 milestone Jul 18, 2019
@mattab mattab modified the milestones: 3.11.0, 3.12.0 Jul 23, 2019
@diosmosis
Copy link
Member

This solves the performance issue by using a single event instead of one on each row, correct?

@tsteur
Copy link
Member Author

tsteur commented Aug 1, 2019

@diosmosis before it was iterating over all rows whenever the table was loaded and was doing work for each row and setting up event listener for each row which is now indeed only a single event.

@diosmosis
Copy link
Member

👍

@diosmosis diosmosis merged commit e4aa8e0 into 3.x-dev Aug 1, 2019
@diosmosis diosmosis deleted the rowactionsdatatable branch August 1, 2019 21:19
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Oct 25, 2019
@mattab
Copy link
Member

mattab commented Oct 27, 2019

Very awesome to have this bug fixed 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants