Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix environment validator test #14672

Merged
merged 1 commit into from Jul 18, 2019
Merged

fix environment validator test #14672

merged 1 commit into from Jul 18, 2019

Conversation

diosmosis
Copy link
Member

@tsteur can you check these changes? They fix the environment validator test, not sure if this is how you'd want it fixed though.

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jul 18, 2019
@diosmosis diosmosis added this to the 3.11.0 milestone Jul 18, 2019
@tsteur
Copy link
Member

tsteur commented Jul 18, 2019

Looks great 👍

@tsteur tsteur merged commit 9a95d4a into 3.x-dev Jul 18, 2019
@tsteur tsteur deleted the fix-build branch July 18, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @tsteur