Only refresh engagement widget when it is on the page #14665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I double checked it should have been only refreshing when the tour widget in the dashboard was loaded/viewed at least once, and only when focusing the window again (eg switching between developer tools and the browser window or between different tabs). It wasn't loaded on every page load within Matomo.
tsteur
added
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I double checked it should have been only refreshing when the tour widget in the dashboard was loaded/viewed at least once, and only when focusing the window again (eg switching between developer tools and the browser window or between different tabs). It wasn't loaded on every page load within Matomo.
fixes #14648