Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new property to store un-encoded site name for use in JS. #14663

Merged
merged 1 commit into from Jul 29, 2019
Merged

Add new property to store un-encoded site name for use in JS. #14663

merged 1 commit into from Jul 29, 2019

Conversation

diosmosis
Copy link
Member

So plugins can use piwik.currentSiteName || piwik.siteName when accessing the current site name.

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 17, 2019
@diosmosis diosmosis added this to the 3.11.0 milestone Jul 17, 2019
@mattab mattab modified the milestones: 3.11.0, 3.12.0 Jul 23, 2019
@tsteur tsteur merged commit f567986 into 3.x-dev Jul 29, 2019
@tsteur tsteur deleted the new-site-name-prop branch July 29, 2019 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @tsteur @mattab