New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
“non well formed numeric value encountered” upon upgrading to 3.10 and php7.3 #14662
Comments
@DeamonMV do you know if that happens when viewing a specific report or sparkline ? |
same issue for me, my new server use MariaDB last version on Debian Linux Buster with PHP 7.3.4-2 |
I did some research on this. Thus, this warning most likely can be avoided by ensuring we only pass numerical values in the $sparkline->setData($values); call in Piwik\Visualization\Sparkline. I will do some more research and come back if I can track it down some more. |
I added some debug code to my setup:
It found these values:
The problem with these values is the space character at the end which makes them non-numerical for php. While debugging I also found this code:
Which makes no sense if both times "Intl_NumberSymbolGroup" is used, so I think it should be "Intl_NumberSymbolDecimal" for $decimalSeparator. |
After thinking about it, I guess it would be good to fix the cause of the appended space character. I will debug some more, this time with a call trace. Maybe we also should check all values with is_numeric() and throw a more meaningful warning if it fails |
My findings after some more debugging: The problematic values come from "bounce_rate" and "funnel_conversion_rate" (and most likely all other percent values). The strings have the form '16 %', after removing the '%' the space was left at the end. My first pull reuquest added a I will create a new PR to solve this issue as well. |
``$validation_code = md5($username . microtime()); |
What is my ENV:
VM server on Hetzner
Matomo version: 3.10.0
MySQL version: 5.7.26
PHP version: 7.3.6-1+0~20190531112735.39+stretch~1.gbp6131b7
What is a problem
Sometimes i get those warning
The text was updated successfully, but these errors were encountered: