In JS tracker generator make sure to reuse same class when creating new file #14660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
Someone might use DI to set a custom file type like this:
The tracker updater would then eg update the file content on the CDN instead of locally. However, because we have a
piwik.js
and amatomo.js
that needs to be updated, thematomo.js
would have still been updated on the local filesystem because it was usingnew File()
hard coded where it should have created basicallynew CdnFile()
.We need this patch on the cloud fyi.