@tsteur opened this Pull Request on July 16th 2019 Member

Background:
Someone might use DI to set a custom file type like this:

  'Piwik\Plugins\CustomPiwikJs\TrackerUpdater' => DI\decorate(function ($previous) {

        $to = new \Piwik\Plugins\MyPlugin\CdnFile('mypath/piwik.js');

        $previous->setToFile($to);

        return $previous;
    }),

The tracker updater would then eg update the file content on the CDN instead of locally. However, because we have a piwik.js and a matomo.js that needs to be updated, the matomo.js would have still been updated on the local filesystem because it was using new File() hard coded where it should have created basically new CdnFile().

We need this patch on the cloud fyi.

@tsteur commented on July 17th 2019 Member

Merging this one as tests pass and we have it in use on production and works there.

This Pull Request was closed on July 17th 2019
Powered by GitHub Issue Mirror