Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old unused test files #14659

Merged
merged 3 commits into from Aug 13, 2019
Merged

Remove old unused test files #14659

merged 3 commits into from Aug 13, 2019

Conversation

Findus23
Copy link
Member

This is a WIP PR to remove all files in tests/ that are not used anymore:

  • tests/lib/jsdoc-toolkit
  • tests/lib/chai-1.9.0
  • tests/lib/mocha-3.1.2

@Findus23 Findus23 added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Jul 15, 2019
@tsteur
Copy link
Member

tsteur commented Jul 29, 2019

@Findus23 are you still working on this? If tests pass we could maybe merge?

@mattab mattab added this to the 3.13.0 milestone Aug 13, 2019
@Findus23
Copy link
Member Author

While there are more things that can be removed, those will need a few changes and a closer look.

So for now this can be merged if the tests pass (as they should)

@Findus23 Findus23 marked this pull request as ready for review August 13, 2019 09:30
@Findus23 Findus23 added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Aug 13, 2019
@tsteur tsteur merged commit 3196206 into 3.x-dev Aug 13, 2019
@tsteur tsteur deleted the remove-test-files branch August 13, 2019 20:37
@Findus23 Findus23 restored the remove-test-files branch October 4, 2019 09:48
@mattab mattab modified the milestones: 3.13.0, 3.12.0 Oct 25, 2019
@mattab mattab added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Oct 25, 2019
@Findus23 Findus23 mentioned this pull request Feb 8, 2020
Closed
@mattab mattab deleted the remove-test-files branch February 10, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Findus23 @tsteur @mattab