Bump lodash from 4.17.11 to 4.17.14 in /tests/lib/screenshot-testing #14655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.14) Signed-off-by: dependabot[bot] <support@github.com>
…/lib/screenshot-testing/lodash-4.17.14 Bump lodash from 4.17.11 to 4.17.14 in /tests/lib/screenshot-testing
|
This isn't that important as this directory isn't included in the released Matomo build, but just used for tests. |
|
@Findus23 Would it make sense to just merge this PR now and gradually update dependencies? |
|
The CI test failed for PHP 5, not PHP 7. |
sgiehl
added
the
c: Tests & QA
|
The library you updated is only used for screenshot testing, which is the build running on PHP 5 only. But that shouldn't be caused by this update. So guess it wouldn't harm to merge that 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated fix by dependabot.