Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only permit scalar values for custom variables #14640

Merged
merged 2 commits into from Jul 10, 2019
Merged

Only permit scalar values for custom variables #14640

merged 2 commits into from Jul 10, 2019

Conversation

katebutler
Copy link

Fixes #14580 (a PHP warning that happens when an array is passed)

@katebutler katebutler added the Needs Review PRs that need a code review label Jul 7, 2019
@katebutler katebutler added this to the 3.11.0 milestone Jul 7, 2019
sgiehl
sgiehl approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsteur tsteur merged commit e7ad74d into 3.x-dev Jul 10, 2019
@tsteur tsteur deleted the 14580 branch July 10, 2019 23:55
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

strlen() expects parameter 1 to be string, array given in strlen called at /core/Tracker/Request.php
4 participants
@katebutler @sgiehl @tsteur @mattab