Update GitHub links in LEGALNOTICE #14637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That should be all. There are still some old links in the CHANGELOG.md, but I think we shouldn't touch them, because changelog is what it is, what do you think about it @tsteur ? Note: Do you still use jquery.truncate? It is in the LEGALNOTICE, but I think it isn't used anymore (not sure).
|
The file for jquery truncate is still in the filesystem but I think it looks it's not used anymore. |
|
CHANGELOG.md we could certainly fix links as well. |
|
Okay, I will change them later as well. 😊 |
Merged
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That should be all.
There are still some old links in the CHANGELOG.md, but I think we shouldn't touch them, because changelog is what it is, what do you think about it @tsteur ?
Note:
Do you still use jquery.truncate?
It is in the LEGALNOTICE, but I think it isn't used anymore (not sure).